New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinIO for testing #177

Open

ThorodanBrom opened this issue Aug 20, 2024 · 3 comments

Assignees

Collaborator

ThorodanBrom commented Aug 20, 2024

No description provided.

ThorodanBrom self-assigned this

Collaborator Author

ThorodanBrom commented Aug 20, 2024

Apart from using MinIO for testing, another thing that is being explored in this is where the code needs to be modified to allow for path-based access as well
- Reason - each integration tests uploads the files it needs to S3 in the setup phase. Virtual-hosting-based access cannot work for this, so the only option is to use path-based.
- Also Self hosted deployment #176

Collaborator

mahimatics commented Sep 30, 2024

MinIO integration is in progress
Once that is done, we need a K8s setup on baremetal

Collaborator Author

ThorodanBrom commented Oct 3, 2024

Potential changes for MinIO support

Config

S3Config object to accomodate all the different S3 config options
- Based off Add support for multiple buckets #185 (comment)
Use awsEndpoint value
s3PathBasedAccess boolean

`DataFromS3`

Pass S3Config object in constructor
Minor change in the way the request is made to accomodate HTTP/HTTPS - https://vertx.io/docs/apidocs/io/vertx/core/http/HttpClient.html#request-io.vertx.core.http.RequestOptions-
Form URL based on s3PathBasedAccess config
- true - add bucket name to path
- false or missing - add bucket name to endpoint as subdomain

Processes

Make sure processes make use of the awsEndpoint and s3PathBasedAccess configs accordingly - especially in ogrinfo and ogr2ogr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment