Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks update groups command is unnecessarily destructive #1942

Open
tim-sparq opened this issue Nov 28, 2024 · 0 comments
Open

databricks update groups command is unnecessarily destructive #1942

tim-sparq opened this issue Nov 28, 2024 · 0 comments
Assignees
Labels
CLI CLI related issues

Comments

@tim-sparq
Copy link

Describe the issue

Running the databricks groups update [group id] command without the --json flag deletes all of the specified group's configuration, including all members, potentially with destructive impact.

Recently this caused a production incident in our environment when all users were silently removed from our workspace's admins group, causing pipelines to break and locking us out of our workspace.

This behaviour - which is undocumented - is unnecessarily destructive. If no configuration is supplied, the command should arguably throw an error, instead of silently removing all users from the specified group. Compare to other major clis (such as az / gcloud) where such a destructive behavior is not possible.

Steps to reproduce the behavior

Please list the steps required to reproduce the issue, for example:

  1. Run databricks groups update [group id], omitting the --json flag

Expected Behavior

The command should return an error notifying the user that no configuration was supplied

Actual Behavior

The command silently deletes all of the specified group's configuration, including all members, potentially with destructive impact

OS and CLI version

macos, Databricks CLI v0.219.0,

Is this a regression?

No

Debug Logs

N/A

@tim-sparq tim-sparq added the CLI CLI related issues label Nov 28, 2024
@shreyas-goenka shreyas-goenka self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI CLI related issues
Projects
None yet
Development

No branches or pull requests

2 participants