Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Distributed fixtures not compliant with dask-jobqueue #569

Open
guillaumeeb opened this issue Aug 7, 2022 · 0 comments
Open

CI: Distributed fixtures not compliant with dask-jobqueue #569

guillaumeeb opened this issue Aug 7, 2022 · 0 comments
Milestone

Comments

@guillaumeeb
Copy link
Member

I hesitated to put this issue as a comment in #567, but I'm under the impression we have two separate problems.

In #562, I override the cleanup fixture from distributed to prevent it from removing the default MainThread loop (so #567 related), but also to make it reload the dask-jobqueue configuration into dask.config. Since distributed last 2022.08.0 version, the loop fixture we used into our tests has also been modified (dask/distributed@172e37f). In this new version, config is also reset, so I directly modify the method distributed.utils_test.reset_config to also reload dask-jobqueue config.

Question is: how could we use these fixtures without these hacks? How to make dask-jobqueue config reset at the same time as the distributed one is reset? Does this need a fix in distributed?

Going further, I have another question of understanding (also expressed here): why do we need the loop fixture? I don't see other Dask cluster deploying system using it. Is this still necessary with SpecCluster?

cc @graingert @jacobtomlinson.

@guillaumeeb guillaumeeb added this to the 0.9 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant