Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple places in code where url suffix is hardcoded to amazonaws.com #39

Open
pshafton opened this issue Jul 5, 2016 · 1 comment
Open

Multiple places in code where url suffix is hardcoded to amazonaws.com #39

pshafton opened this issue Jul 5, 2016 · 1 comment

Comments

@pshafton
Copy link

pshafton commented Jul 5, 2016

The amazon China endpoint ends with amazonaws.com.cn instead of amazonaws.com there are a few places in the codebase where the url is hardcoded to the amazonaws.com endpoint. We probably need to add a per region suffix lookup function to allow this to work with amazon China.
pshafton pushed a commit to pshafton/dasein-cloud-aws that referenced this issue Jul 7, 2016
Add abstraction for determining the aws url suffix dependent upon reg…
dbcc684 
…ion. Fix for Issue dasein-cloud#39
@pshafton
Copy link
Author

pshafton commented Jul 7, 2016

Possible fix with this pull request:

#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pshafton