-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigInteger.longValue() missing #30
Comments
Ok, it seems that the Check this:
|
@stevenroose was that in javascript or dartvm, or both? |
That was in dartvm. I did not test in JS
|
Would have to think about this more... Dont have a good plan about "fixing" this. |
CORRECTION: see first comment
Java's BigInteger has a
longValue()
getter to return the BigInteger's value as a long.dart-bignum's only has an
intValue()
. While Dart does not have a long type, the integer type does support numbers larger than 32 bits. However, theintValue()
getter caps the value at 32 bits.So there should be a
longValue()
getter that allows for numbers up to 64 bits. Dart supports 64-bit integers and JS also supports ints larger than 32 bits.I tried to look at it myself, but I don't fully understand the code. (Does the JS BigInteger have a
longValue()
?)The text was updated successfully, but these errors were encountered: