Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about list values in LazyMergedMapViews? #117

Open
jakemac53 opened this issue Oct 24, 2024 · 2 comments
Open

What to do about list values in LazyMergedMapViews? #117

jakemac53 opened this issue Oct 24, 2024 · 2 comments

Comments

@jakemac53
Copy link
Contributor

I don't know what to do about these, there is no obvious answer.

For now I am adding a check that they have the same length, and just returning the left one, but that is pretty clearly flawed.

@davidmorgan
Copy link
Contributor

I think we'll anyway need to revisit how we handle the data for merging, so this can be part of that.

We could return a list wrapper that knows both lists and lazily checks for equality :)

An entirely different approach would be to only send differences to previous query results, so that there are never duplicates in the merge.

@jakemac53
Copy link
Contributor Author

We could return a list wrapper that knows both lists and lazily checks for equality :)

The problem is we don't even have well defined equality.... if we have a list of Map objects, which are each incomplete model representations....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants