Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leak-tracker: Support pure Dart package #257

Open
Solido opened this issue Dec 2, 2024 · 7 comments
Open

leak-tracker: Support pure Dart package #257

Solido opened this issue Dec 2, 2024 · 7 comments

Comments

@Solido
Copy link

Solido commented Dec 2, 2024

Hi,

leak-tracker is an important tool in the dart world as the language is moving from being mainly front to also model rich world logic.

I'm working on a large package that would greatly benefits from memory insights while dealing with deep data structures and operations.

Thanks!

@polina-c
Copy link
Contributor

polina-c commented Dec 6, 2024

Thanks for filing it! How about design discussion? I sent you message in Twitter to schedule.

@polina-c
Copy link
Contributor

polina-c commented Jan 5, 2025

Relevant issue: flutter/flutter#161132

@polina-c
Copy link
Contributor

polina-c commented Jan 5, 2025

Question: can you add dev dependency on flutter_test and use 'testWidgets' instead of 'test' to get leak tracking for your tests?
If this works out, we just need to document this.

@Solido
Copy link
Author

Solido commented Jan 5, 2025

It should be possible but it require to reconfigure the project from pure dart to flutter as we also need to import the flutter sdk.

@polina-c
Copy link
Contributor

polina-c commented Jan 5, 2025

Not the entire project, but tests only. And another option is to have separate flutter project with just tests.
But, yes, ideally we want to update the pure dart method 'test' to support leak tracking.
First step would be to create one page design doc (template, example) and review it with team.

@Solido
Copy link
Author

Solido commented Jan 5, 2025

Currently I'm using a monorepo with all logics and tests relying on dart then another flutter project build on the logic. To use flutter test on logic would mean to import Flutter sdk which is not an option for later build purpose.

Flutter projects would not cover the same testing surface thus a case to check for memory leaks first on a pure dart project and then later on widgets.

@polina-c
Copy link
Contributor

polina-c commented Jan 5, 2025

Currently I'm using a monorepo with all logics and tests relying on dart then another flutter project build on the logic. To use flutter test on logic would mean to import Flutter sdk which is not an option for later build purpose.

Flutter projects would not cover the same testing surface thus a case to check for memory leaks first on a pure dart project and then later on widgets.

Makes sense. Then next step is a one-page design doc to enable leak tracking in dart test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants