Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health workflow: Mono repo commit message format #332

Open
dcharkes opened this issue Dec 20, 2024 · 4 comments
Open

Health workflow: Mono repo commit message format #332

dcharkes opened this issue Dec 20, 2024 · 4 comments

Comments

@dcharkes
Copy link

mono_repo request: could we standardize on [pkg-name] XYZ for commit messages?

posted by @kevmoo

I think a check for this could fit well in the health workflow. cc @mosuem

@mosuem
Copy link
Member

mosuem commented Jan 2, 2025

We could add this check. I would be hesitant to add this for all dart-lang repos though, and we should probably have that discussion/decision first before doing the implementation work.

cc @devoncarew

@devoncarew
Copy link
Member

Hmm, we could dogfood something like this w/ an off-the shelf tool before doing something like adding it to the health checks. This could be via a git hook, or a github action (ala https://github.com/marketplace/actions/gs-commit-message-checker).

@devoncarew
Copy link
Member

fwiw, I don't have a particular opinion about using package prefixes for commit messages, but haven't really given it any thought.

@dcharkes
Copy link
Author

dcharkes commented Jan 2, 2025

Hmm, we could dogfood something like this w/ an off-the shelf tool before doing something like adding it to the health checks. This could be via a git hook, or a github action (ala https://github.com/marketplace/actions/gs-commit-message-checker).

Dogfooding on dart-lang/native as per:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants