Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSRMatrix::append() on empty matrix #727

Open
pdamme opened this issue May 16, 2024 · 0 comments
Open

CSRMatrix::append() on empty matrix #727

pdamme opened this issue May 16, 2024 · 0 comments
Labels
bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.

Comments

@pdamme
Copy link
Collaborator

pdamme commented May 16, 2024 •
edited
Loading

The current implementation of the append mechanism of CSRMatrix (prepareAppend(), append(), finishAppend()) seems to be incorrect when the number of rows and/or the number of columns of the matrix is zero.

A similar problem existed for DenseMatrix and was fixed in 2b4f086.

Thanks to @AlexRTer for pointing out this problem in #722.
@pdamme pdamme added bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A mistake in the code. good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdamme