Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish scl-lib integration #8

Open
danyill opened this issue Feb 6, 2024 · 2 comments
Open

Finish scl-lib integration #8

danyill opened this issue Feb 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@danyill
Copy link
Owner

danyill commented Feb 6, 2024

Add scl-lib will ensure adequate overall test coverage.

There's a bit more to do here.

Also we don't want deleting of supervisions to only sometimes remove the LN.
@danyill danyill added the enhancement New feature or request label Feb 6, 2024
@danyill danyill added this to the v1 milestone Feb 6, 2024
@danyill
Copy link
Owner Author

danyill commented Feb 10, 2024

removeSupervision is now merged allowing LN or Val removal.

@danyill
Copy link
Owner Author

danyill commented Mar 29, 2024

The main missing item is associated with creating new supervision LNs with no Val element.

For others which would be useful, see:

OpenEnergyTools/scl-lib#79
OpenEnergyTools/scl-lib#80
OpenEnergyTools/scl-lib#83

I don't think this is necessary for the first release of this plugin, so I'll de-milestone it.

@danyill danyill removed this from the v1 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danyill