Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yazi: unreadable status bar #683

Closed
blackxored opened this issue Dec 14, 2024 · 4 comments · Fixed by #719
Closed

Yazi: unreadable status bar #683

blackxored opened this issue Dec 14, 2024 · 4 comments · Fixed by #719
Labels
bug Something isn't working properly

Comments

@blackxored
Copy link

I'm not sure if this is due to yazi 0.4.x, but the status bar has become unreadable. I'm using gruvbox-dark-hard base16 scheme, here's how it looks:

image

Any idea how to fix? Thank you!
@danth danth added the bug Something isn't working properly label Dec 29, 2024
@danth
Copy link
Owner

danth commented Dec 29, 2024

It looks like there were some breaking changes in release 0.4.0: sxyazi/yazi#1772 (comment)

The Stylix module probably needs to be updated.

@xokdvium xokdvium mentioned this issue Jan 1, 2025
Merged
@xokdvium
Copy link
Contributor

xokdvium commented Jan 1, 2025

For theming related changes we can reference upstream theme changes:

nixpkgs flake input is quite old and still has yazi 0.3.x, even though 0.4.0 hit unstable several weeks ago. I'm not keen on supporting several versions in the module, since the breakage is pretty extensive. Should we bump stylix nixpkgs input and drop support for 0.3.x theming altogether? My concern with this approach is that 24.11 shipped with 0.3.3 and some stylix users might be using stylix master with nixos-24.11.

@trueNAHO
Copy link
Collaborator

trueNAHO commented Jan 1, 2025

nixpkgs flake input is quite old and still has yazi 0.3.x, even though 0.4.0 hit unstable several weeks ago. I'm not keen on supporting several versions in the module, since the breakage is pretty extensive.

We follow the approach of only supporting the latest versions, unless multiple version are simultaneously required, like with gcc or llvm. However, this is currently not the case for any Stylix modules.

Should we bump stylix nixpkgs input and drop support for 0.3.x theming altogether?

Yes.

My concern with this approach is that 24.11 shipped with 0.3.3 and some stylix users might be using stylix master with nixos-24.11.

Mixing LTS with non-LTS should be expected to break. The recommended LTS usage is nixpkgs/nixos-24.11 + stylix/release-24.11.

@blackxored
Copy link
Author

Looks good now, thank you!

pinarruiz pushed a commit to pinarruiz/stylix that referenced this issue Jan 4, 2025
@xokdvium @pinarruiz
yazi: add testbed, resolve 0.4.0 breaking changes, and improve names (d…
ccfef8d 
…anth#719)

Add a testbed and resolve the 0.4.0 breaking changes [2] [3] [4].

Migrate the highlight colors to mnemonics with the following script to
improve readability and simplify the process of reusing upstream
templates [4]:

    colors_base=(
      "base08" "base09" "base0A" "base0B" "base0C" "base0D" "base0E"
      "base0F"
    )

    colors_name=(
      "red" "orange" "yellow" "green" "cyan" "blue" "magenta" "brown"
    )

    for i in "${!colors_base[@]}"; do
      sed \
        --in-place \
        "s/${colors_base[i]}/${colors_name[i]}/g" \
        modules/yazi/hm.nix
    done

[1]: sxyazi/yazi#1772
[2]: sxyazi/yazi#1927
[3]: sxyazi/yazi#1953
[4]: https://github.com/yazi-rs/flavors/blob/main/scripts/catppuccin/template.toml

Closes: danth#604
Closes: danth#683
Link: danth#719

Reviewed-by: NAHO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working properly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

yazi: add testbed, adapt to 0.4.x changes xokdvium/stylix
4 participants
@blackxored @danth @trueNAHO @xokdvium