Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grpclib dependency optional #565

Open
timwie opened this issue Mar 23, 2024 · 1 comment
Open

Make grpclib dependency optional #565

timwie opened this issue Mar 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@timwie
Copy link

timwie commented Mar 23, 2024

First off, thank you for this tool, I was barely able to work with the Python code that protoc generates by default.

I believe that for my usecase, the grpclib dependency (and the indirect dependency on four other packages) is unnecessary, and it might be worth thinking about making it optional, and enabling it via an extra. I assume this would be a breaking change, since I don't think you can make extras enabled by default. But maybe it's an idea for v2 or a future major release.

Basically all I need is to decode messages arriving from a socket. For that I don't need more than what is imported in the generated files: Message, Enum, and the *_field functions. As far as I can tell, these do not depend on grpclib.

@Gobot1234 Gobot1234 added the enhancement New feature or request label Mar 24, 2024
@Gobot1234
Copy link
Collaborator

Yeah I agree it'd massively reduce the number of deps I have personally have as well, seems related to #328. Having both options as extras would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants