Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache results of all aws calls in refresh loop #8

Open
colinliddlemyob opened this issue Feb 26, 2020 · 2 comments
Open

Cache results of all aws calls in refresh loop #8

colinliddlemyob opened this issue Feb 26, 2020 · 2 comments

Comments

@colinliddlemyob
Copy link
Contributor

It's taking a while to refresh metrics, which can cause timeouts for prometheus in the default configuration (10s scrape timeout). The refresh loop could be changed to cache all results from AWS calls to ensure that scraping metrics returns quickly
@colinliddlemyob
Copy link
Contributor Author

Again, I'm happy to do this change

@colinliddlemyob
Copy link
Contributor Author

I've done the change on my fork, could be rearchitected to make it a bit nicer but it does the job:
https://github.com/colinliddlemyob/aws-limits-exporter/tree/add-result-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinliddlemyob