Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery F429ZI board is shown in VSCode+Extension4Arduino as "undefined" #45

Open
caniggia1 opened this issue Oct 29, 2017 · 3 comments

Comments

@caniggia1
Copy link
Contributor

caniggia1 commented Oct 29, 2017

Can you please remove spaces before and after the "=" in this line:
https://github.com/danieleff/STM32GENERIC/blob/master/STM32/boards.txt#L680

It will be also consistent with other boards.

@ChrisMicro
Copy link

Why should it be consistent ?

@caniggia1
Copy link
Contributor Author

caniggia1 commented Oct 29, 2017

It's not about consistence, please just forget the last line.
Discovery F429ZI board is shown in VSCode+Extension4Arduino as "undefined", because of this spaces.
Just this board have spaces around "=". And if i remove them, then it's shown as "Discovery F429ZI" and not as "undefined".
I know this repo is not ment particularly for VSCode+Extension4Arduino,
but all other boards in this file don't have spaces around "=", so why thisone should?
And it will also make life a little bit easier :) for us who use VSCode+Extension4Arduino.

@ChrisMicro
Copy link

Ah, ok.
Probably it is the best, if you fork the repo and correct the error because Daniel seems to be for a longer "offline".
You could place a pull request so he can merge the change when he is back again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants