Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error: NOT_SUPPORTED_SAMPLE_RATE when using higher bitrate audio output devices and noise-cancellation #261

Open
hramos opened this issue Jan 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@hramos
Copy link

hramos commented Jan 8, 2025

This issue can be reproduced using the Daily Prebuilt client.

Expected behavior

Ideally, higher bitrate output devices should be supported when background noise reduction is enabled. Alternatively, the error should be handled by Daily and surfaced as a documented error event. This would allow developers to handle the issue in custom Daily call clients.

Describe the bug (unexpected behavior)

If the selected output device is configured to use a higher bitrate (e.g. 24-bit 192.0 kHz), an uncaught error will be thrown if background noise reduction is enabled (the noise-cancellation audio processor input setting).

VM6985:4 Uncaught (in promise) Error: NOT_SUPPORTED_SAMPLE_RATE
    at E.createNoiseFilter (eval at <anonymous> (daily-esm.js:1:1), <anonymous>:4:2781999)
    at eval (eval at <anonymous> (daily-esm.js:1:1), <anonymous>:4:465406)
    at new Promise (<anonymous>)
    at e.eval (eval at <anonymous> (daily-esm.js:1:1), <anonymous>:4:465377)
    at Generator.next (<anonymous>)
    at e (eval at <anonymous> (daily-esm.js:1:1), <anonymous>:4:1451236)
    at n (eval at <anonymous> (daily-esm.js:1:1), <anonymous>:4:1451447)

Steps to reproduce

This issue has been reproduced on macOS Sequoia 15.2:

  1. Open the Audio MIDI Setup utility, which is packaged with macOS.

  2. Select an audio device which supports higher bitrates. In this particular case, we're using a Fosi Audio DAC-Q4 and a Reiyin DA-DD DAC. Both devices support higher bitrates, and setting up either one of them to use a higher bitrate will trigger the error.
    Screenshot 2025-01-07 at 12 17 15 PM

  3. Select 24-bit 192.0 kHz as the desired sample rate for the device.
    Screenshot 2025-01-07 at 12 17 19 PM

  4. Join a Daily test call, ideally using Daily Prebuilt as this will ensure the error is coming from the Daily library and not our own code (e.g. open your equivalent of https://foobar.daily.co/RMxyz123 in a browser, in this case we used Google Chrome)

  5. For your audio output device, choose the audio device that you configured in step 3.

  6. Click on "Reduce" to enable background noise reduction.

Observe the error in the console.

Screenshot 2025-01-08 at 12 45 24 PM

Screenshots

See above.

System information

  • Device: M4 MacBook Pro
  • OS, version: macOS Sequoia 15.2
  • Browser, version: Google Chrome Version 131.0.6778.205

Additional context

Daily versions:

    "@daily-co/daily-js": "^0.74.0",
    "@daily-co/daily-react": "^0.22.0",
@hramos hramos added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant