-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE-REQUEST] picture-in-picture event #244
Comments
@mklepaczewski this is certainly possible. Before we add this, would you mind explaining the use case you have in mind? |
@markbackman We want to apply lower video quality settings when user enables picture-in-picture. PiP usually uses a smaller window, which provides an opportunity to save bandwidth for users on data plan. |
Thanks for the info, @mklepaczewski. Is this for a custom app or Daily Prebuilt? If it's Daily Prebuilt, the Prebuilt application is going to override any calls to If this is for a custom app, there are browser level PiP APIs that I'd recommend using: https://developer.mozilla.org/en-US/docs/Web/API/Picture-in-Picture_API#events. |
Thank you for the update. At the moment, we still use Daily Prebuilt. We use |
Since you're using P2P calls, are there always 2 people in a call? If so, you can listen to the |
@markbackman Yes, that will do, thank you. |
@markbackman I don't think it is possible to listen to enterpictureinpicture on iframe. I created a demo demonstrating this: https://codesandbox.io/p/devbox/pfyxlp I think that listening to enterpictureinpicture isn't solution to this problem. |
Ahh, yes. The event doesn't bubble up to the parent frame. We can add this request to our backlog. |
Thank you, looking forward to this feature. |
Reopening as our tests showed that the proposed solution by @markbackman indeed doesn't work due to the issue reported by @Zupken |
Feature request
Fire an event when the user enables picture-in-picture. Also, if possible, fire an event when the user disables it.
Why you need this
We want to apply different video settings when picture-in-picture is enabled.
The text was updated successfully, but these errors were encountered: