Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically scroll the container #69

Open
rraziel opened this issue Jan 8, 2019 · 12 comments
Open

Automatically scroll the container #69

rraziel opened this issue Jan 8, 2019 · 12 comments

Comments

@rraziel
Copy link

rraziel commented Jan 8, 2019

Hello,

This module works great, however a really nice feature would be the ability for the drag selection to scroll the container when going out of (visible) bound.

Unless such a feature already exists and I'm using the component incorrectly, which is entirely possible.

Thanks

@d3lm
Copy link
Owner

d3lm commented Jan 8, 2019

Hey @rraziel, thanks! I am glad and happy that it works nice for you.

This is indeed a nice feature to have. Would you be up to take a look at this and send a PR? I am more than happy to assist you and help you with anything that comes up. I would really appreciate any help.

Any remarks on your end @timdeschryver?

@timdeschryver
Copy link
Contributor

Yea, why didn't we think of this 😅
I think it would be a great addition!

@d3lm
Copy link
Owner

d3lm commented Feb 23, 2019

@rraziel So how do you think should this behave when there are multiple scroll containers? Cause you could have the page that is scrollable as well as the select-container which might be scrollable too. You think that the container is enough because I don't want to make this too complex and try to keep the lib as lightweight as possible.

Ideas @timdeschryver?

@timdeschryver
Copy link
Contributor

Personally, I would expect that the direct parent would scroll with the mouse movement.
If every container scrolls, it would look a bit funny imho 😅

@d3lm
Copy link
Owner

d3lm commented Feb 24, 2019

Yep totally.

@rraziel
Copy link
Author

rraziel commented Feb 24, 2019

I'm not sure how reliable this would be - especially considering people may also use extra components for infinite scroll - but I expect finding the first scrollable ancestor might work?

@d3lm
Copy link
Owner

d3lm commented Feb 25, 2019

@rraziel Yep, that might be enough.

@suhailsalim
Copy link

@d3lm Any update on this ?
Thanks. :)

@d3lm
Copy link
Owner

d3lm commented May 15, 2019

Not yet. Haven't had the time to work on this. As this library is open source I would appreciate any help and maybe @suhailsalim you wanna take a stab at this and send a PR if this is a pressing issue?

@d3lm
Copy link
Owner

d3lm commented May 15, 2019

Or of course anyone else is also welcome to send a PR to introduce this feature.

@kinnu69
Copy link

kinnu69 commented Feb 3, 2023

any update on this feature?

@d3lm
Copy link
Owner

d3lm commented Feb 7, 2023

@kinnu69 No, I don't have the capacity right now to work on this and would welcome a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants