Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exclude matching #1

Open
d-Rickyy-b opened this issue Nov 17, 2020 · 2 comments
Open

Improve exclude matching #1

d-Rickyy-b opened this issue Nov 17, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@d-Rickyy-b
Copy link
Owner

Currently the matching doesn't perfectly work like .gitignore filtering.
@d-Rickyy-b d-Rickyy-b changed the title Improve matching Improve exclude matching Nov 17, 2020
@d-Rickyy-b d-Rickyy-b added the enhancement New feature or request label Nov 17, 2020
@d-Rickyy-b
Copy link
Owner Author

Should work more like that: https://labs.consol.de/de/development/git/2017/02/22/gitignore.html

Also nice tool for testing globbing: https://globster.xyz/

@d-Rickyy-b
Copy link
Owner Author

Improved in 0b25309 - still not perfect.

The best performing way of excluding would be to skip processing of certain sub directories during filepath.Walk: https://golang.org/pkg/path/filepath/#WalkFunc

We just need to return filepath.Skipdir within the filepath.Walk WalkFn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-Rickyy-b