-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cytoscape v4 -- planning for breaking API changes #2019
Comments
Does this mean that it would include classes as well as other data? Is there any way currently to get the list of classes an element has? |
|
Since a |
Yes, but that wouldn't have to be a breaking (v4) change. The old key could still be supported. Edit: We may want to use |
This issue is for discussing v4 API -- i.e. breaking API changes. If you have a general feature in mind that is additive w.r.t. API, then feel free to make an ordinary feature request and the corresponding pull request. |
Brainstorming of improvements that would cause breaking changes for a potential, future v4:
Modernising:
package.json
. This breaks support for CJS code that is bundled by Webpack. See alsoexports
(e.g. is-promise).Promise
,Set
,Map
, etc.Improving formatting & naming:
ele.json()
returnsclasses
as an array0.5
is the same as50%
. In v3, if you specify0.5
, you will get0.5%
.{ nodes: [], edges: [] }
elements JSON format no longer the default forcy.json()
export. Instead use, the plain array format.core
selector tocy
, by default. Thecore
value should still work, but it won't be returned bycy.json()
.Improved defaults:
<position>-arrow-width
value tomatch-line
(previously1px
) (✨ Add <position>-arrow-width property for hollow shapes #3194 Add edge <position>-arrow-width for hollow shapes #3191)Removing deprecated features & other mistakes:
cy.forceRender()
. Deprecated long ago.ele.renderedStyle()
(Deprecated in Deprecateele.renderedStyle()
#2223)cy.batchData()
. Deprecated long ago.concentric
scratch values when running the concentric layout. The programmer can store values themselves.cy.style()
to only be a JSON setter. Ref: remove/update a cytoscape.js style #2637 (comment)width: label
andheight: label
. Ref. Background SVG image shrinking on newer versions (on 3.1.2 works ok) #2713Moving features to external extensions or libraries:
cose
from the core bundle and make it an external extension. The force-directed layout that a programmer should choose by default isfcose
.selectionType: 'additive'
from the core lib and turn it into an extensionThe text was updated successfully, but these errors were encountered: