Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to profiling chapter - Issue on page /docs/07-profiling.html #17

Open
jccaicedo opened this issue Sep 19, 2022 · 5 comments
Assignees

Comments

@jccaicedo
Copy link
Member

  • This chapter should come before training!
  • The order of profiling options should be:
    • The Cell Painting CNN first
    • ImageNet pre-trained second
    • Your own trained model third

Also, is it true that we strongly recommend to prepare the dataset (compression) before profiling? I thought DeepProfiler was able to compute features for images without compression (which is desirable if the dataset is too large). Our model is robust to illumination changes, so this should not affect downstream performance. I recommend to remove this and instead clarify that DeepProfiler does not need compression to profile (I added a Note with this comment in Chapter 3).

@Arkkienkeli
Copy link
Member

  • Reordered chapters (swap training and profiling)
  • Reordered profiling sections
  • Removed recommendation about data pre-procsessing from profiling section ; I kept it in training only as we discussed yesterday.

@Arkkienkeli
Copy link
Member

Cell Painting CNN: expects pre-defined order of Cell Painting channels.

@Arkkienkeli
Copy link
Member

Arkkienkeli commented Sep 26, 2022

Cell Painting CNN: expects pre-defined order of Cell Painting channels.

Added this information.

@Arkkienkeli
Copy link
Member

Added links to notebooks and the code.

@jccaicedo
Copy link
Member Author

I could not find the links to notebooks or code. Was this part of this page?

In any case, it'd be great to link to the following resources, just to make the page navigation friendly:

  • Links to config files for each profiling option.
  • Links to the config file section that talks about profiling options.

If you add this, you can close this issue @Arkkienkeli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants