From 607e1dc290d4d14520efda6ef3daa2406382f9b9 Mon Sep 17 00:00:00 2001 From: Alex Schwartz Date: Fri, 22 Sep 2023 08:20:53 -0400 Subject: [PATCH 1/4] docs: update installation requirements in contributing.md --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b2ba87e7ee8c..0228d2f9fea5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -207,6 +207,7 @@ You must have the following installed on your system to contribute locally: - [`Node.js`](https://nodejs.org/en/) (See the root [.node-version](.node-version) file for the required version. You can find a list of tools on [node-version-usage](https://github.com/shadowspawn/node-version-usage) to switch the version of [`Node.js`](https://nodejs.org/en/) based on [.node-version](.node-version).) - [`yarn`](https://yarnpkg.com/en/docs/install) - [`python`](https://www.python.org/downloads/) (since we use `node-gyp`. See their [repo](https://github.com/nodejs/node-gyp) for Python version requirements.) +- `g++` and `make` (command: `sudo apt install g++ make` on Debian-based systems) ### Getting Started From effae618b23e15493022388e48b8c947c457d6f0 Mon Sep 17 00:00:00 2001 From: Alex Schwartz Date: Sat, 23 Sep 2023 09:43:24 -0400 Subject: [PATCH 2/4] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0228d2f9fea5..3426e1ca7e28 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -207,7 +207,7 @@ You must have the following installed on your system to contribute locally: - [`Node.js`](https://nodejs.org/en/) (See the root [.node-version](.node-version) file for the required version. You can find a list of tools on [node-version-usage](https://github.com/shadowspawn/node-version-usage) to switch the version of [`Node.js`](https://nodejs.org/en/) based on [.node-version](.node-version).) - [`yarn`](https://yarnpkg.com/en/docs/install) - [`python`](https://www.python.org/downloads/) (since we use `node-gyp`. See their [repo](https://github.com/nodejs/node-gyp) for Python version requirements.) -- `g++` and `make` (command: `sudo apt install g++ make` on Debian-based systems) +- `cmake`, `g++` and `make` (command: `sudo apt install cmake g++ make` on Debian-based systems) ### Getting Started From 153b48f77c1fdb1d08f2aa5e05990e9363047474 Mon Sep 17 00:00:00 2001 From: Alex Schwartz Date: Sat, 23 Sep 2023 09:47:30 -0400 Subject: [PATCH 3/4] add links --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3426e1ca7e28..bc659c2c6ca2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -207,7 +207,7 @@ You must have the following installed on your system to contribute locally: - [`Node.js`](https://nodejs.org/en/) (See the root [.node-version](.node-version) file for the required version. You can find a list of tools on [node-version-usage](https://github.com/shadowspawn/node-version-usage) to switch the version of [`Node.js`](https://nodejs.org/en/) based on [.node-version](.node-version).) - [`yarn`](https://yarnpkg.com/en/docs/install) - [`python`](https://www.python.org/downloads/) (since we use `node-gyp`. See their [repo](https://github.com/nodejs/node-gyp) for Python version requirements.) -- `cmake`, `g++` and `make` (command: `sudo apt install cmake g++ make` on Debian-based systems) +- [`cmake`](https://cmake.org/), [`g++`](https://gcc.gnu.org/), and [`make`](https://www.gnu.org/software/make/) (command: `sudo apt install cmake g++ make` on Debian-based systems) ### Getting Started From 6474e656a9c3f89c0e286bd29c0cc23e6aeb675b Mon Sep 17 00:00:00 2001 From: Alex Schwartz Date: Sat, 23 Sep 2023 09:50:03 -0400 Subject: [PATCH 4/4] update g++ link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bc659c2c6ca2..eb42274dd8f8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -207,7 +207,7 @@ You must have the following installed on your system to contribute locally: - [`Node.js`](https://nodejs.org/en/) (See the root [.node-version](.node-version) file for the required version. You can find a list of tools on [node-version-usage](https://github.com/shadowspawn/node-version-usage) to switch the version of [`Node.js`](https://nodejs.org/en/) based on [.node-version](.node-version).) - [`yarn`](https://yarnpkg.com/en/docs/install) - [`python`](https://www.python.org/downloads/) (since we use `node-gyp`. See their [repo](https://github.com/nodejs/node-gyp) for Python version requirements.) -- [`cmake`](https://cmake.org/), [`g++`](https://gcc.gnu.org/), and [`make`](https://www.gnu.org/software/make/) (command: `sudo apt install cmake g++ make` on Debian-based systems) +- [`cmake`](https://cmake.org/), [`g++`](https://gcc.gnu.org/onlinedocs/libstdc++/), and [`make`](https://www.gnu.org/software/make/) (command: `sudo apt install cmake g++ make` on Debian-based systems) ### Getting Started