-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trashAssetsBeforeRuns=false keeps all versions of screenshots but not of videos #8280
Comments
When run as set to it('write to file', () => {
expect(true).to.be.false
}) {
"trashAssetsBeforeRuns": false
} After 2 |
This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided. |
This issue has been closed due to inactivity. |
Is there a fix for this? |
Hey, I believe this might be happening because while writing screenshot to disk here , the path generation checks for given path existing or not, and updates the path according to the overwrite flag here. From what I see in video capture code here there is no such logic to detect existing paths. I'm not sure if the actual video writing is done in some other place where we are doing such check, but from a first glance, I think this might be the reason of videos not getting persisted. @jennifer-shehane Is this issue open for contributions? If so can I try to make a PR for it? This would be my first time contributing to cypress, is there anything other than Contributing.md I should take a look at if I work on this? Thanks! |
@YJDoc2 Yes, if tests are written we would accept PRs to fix bugs |
Hey @jennifer-shehane , I have opened #30673 for this, and need a bit of help with adding tests in there. I have mentioned details in the PR description, do I need to do something else to get it reviewed or someone from cypress will review it when they get time? |
Current behavior:
In my cypress.json I have the option
The test cases are running every day with
./node_modules/.bin/cypress run
It is kept all versions of the screenshots for each run, but not for the videos. The videos get overwritten
Desired behavior:
The videos should not get overwritten. I would like to keep all the videos of each run
Test code to reproduce
add "trashAssetsBeforeRuns": false to cypress.json
Versions
cypress version 4.12.1
The text was updated successfully, but these errors were encountered: