You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently skipping the element comparison on the highlight in the dom_hitbox tests after upgrading to React 18 in #30511. What looks to be occurring, is that the DOM reference fetched in elementFromPoint is a stale detached DOM reference of the highlight container over the button. In React 17, the "elementFromPoint" and "div[data-layer=Content]" share the same reference. Since updating the Reporter to React 18, this is no longer the case. The element looks to be rerendered and the previous reference detached. We will need to come up with a different way to test this.
Desired behavior
the element retrieved from elementFromPoint should be the same from the queried DOM
Test code to reproduce
see correct target position during click in dom_hitbox cypress test inside @packages/driver
Cypress Version
N/A
Node version
N/A
Operating System
N/A
Debug Logs
No response
Other
No response
The text was updated successfully, but these errors were encountered:
AtofStryker
changed the title
React 18 highlight element test has right element, but stale coordinates
React 18 highlight element test has right element, but stale styles
Nov 4, 2024
Current behavior
We are currently skipping the element comparison on the highlight in the
dom_hitbox
tests after upgrading to React 18 in #30511. What looks to be occurring, is that the DOM reference fetched inelementFromPoint
is a stale detached DOM reference of the highlight container over the button. In React 17, the"elementFromPoint"
and"div[data-layer=Content]"
share the same reference. Since updating the Reporter to React 18, this is no longer the case. The element looks to be rerendered and the previous reference detached. We will need to come up with a different way to test this.Desired behavior
the element retrieved from
elementFromPoint
should be the same from the queried DOMTest code to reproduce
see
correct target position during click
indom_hitbox
cypress test inside@packages/driver
Cypress Version
N/A
Node version
N/A
Operating System
N/A
Debug Logs
No response
Other
No response
The text was updated successfully, but these errors were encountered: