-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cy.visit secure error when _ used in hostname #2998
Comments
Could you try setting You can always set other flags directly #715 (comment), but I think disabling chromeWebSecurity should work in your case. |
We also have same issue with wildcard certificate, issued by Letsencrypt, when we try to run tests against subdomain. After researches, found out, that underscore |
@alexbridge Thanks so much for leaving a comment! This does appear to be the root of the issue. I believe this is a legitimate error due to
|
I just wanna say that the
|
@jennifer-shehane underscores are perfectly valid in sub-domains, which is the reported issue, and also one we encountered. Underscores are not valid in hostnames, but that should be obvious because no one would be able to get a hostname on a network or in a registered domain. A concise summary of the distinction can be found here: https://stackoverflow.com/a/2183140 Can this issue be re-opened? |
@DuncanHills Do you have a situation where an underscore in the subdomain is causing an error? Can you give more detail? |
@jennifer-shehane a Cypress test harness is getting cert errors when used against with a subdomain that contains underscores, covered by a public wildcard cert. I can follow up with more details soon. |
+1 We ran into the same problem. (wildcard certificate, and underscore |
@Benjaminhu Did you find any solution? |
@AshrafShaik001 Yes, we changed the name of the host (fortunately, the developer address only). |
+1 Just encountered this issue. According to this: https://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it This should be fixed. Until it is fixed, I am forced to change the url, which is not ideal. |
This just blocked the company I work at from being able to implement cypress at all. We can't change subdomain names that have an underscore, and subdomains with an underscore are valid. This issue needs to be addressed. |
The RFC has a preferred name syntax outlined here.
Additionally SSL certs are no longer issued to subdomains with underscores for this exact reason. See this link. It's clearly strongly recommended to not use underscores in subdomains, but it is not uniformly enforced across browsers. We haven't personally spent time to look into why this is not working, but would be open to a pull request that allows URLs with underscores to display as they would in a normal browser. Example test it('runs', () => {
cy.visit('https://my_sarisari_store.typepad.com/');
}); |
This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided. |
I can confirm the issue persists. We changed our subdomains to overcome it, but it would be nice if Cypress could handle this natively. |
Current behavior:
When I try to visit my app, which located in JenkinsCI, I encounter an error:
When I put URL in the browser app open, this error only in Cypress sandbox
Versions
Operating System: Ubuntu 16.04
Cypress Version: 3.1.3
Browser Version: Chrome 70
The text was updated successfully, but these errors were encountered: