Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Require @packages/example to be reviewed before deployment #29147

Open
cacieprins opened this issue Mar 14, 2024 · 5 comments
Open

Chore: Require @packages/example to be reviewed before deployment #29147

cacieprins opened this issue Mar 14, 2024 · 5 comments
Labels
pkg/example This is due to an issue in the packages/example directory prevent-stale mark an issue so it is ignored by stale[bot] process: release Related to our internal release process

Comments

@cacieprins
Copy link
Contributor

Current behavior:

@packages/example deploys directly to production example.cypress.io as soon as the deploy command executes, via the gh-pages tool.

As a stopgap to prevent outages:

  • gh-pages should be a protected branch
  • the deploy command in @packages/example should open a pull request to gh-pages instead of committing directly

In the future:

  • cypress-example-kitchensink should deploy continuously to a staging environment
  • deploys of cypress-example-kitchensink to example.cypress.io are handled via circleci in the cypress-example-kitchensink repository, triggered by creating a github release as a part of the cypress deploy process
    • this leaves the door open for an automated release triggered by cypress ci, once the cypress release process is automated
@cacieprins cacieprins changed the title Chore: Require @packages/exampl to be reviewed before deployment Chore: Require @packages/example to be reviewed before deployment Mar 14, 2024
@jennifer-shehane jennifer-shehane added pkg/example This is due to an issue in the packages/example directory process: release Related to our internal release process labels Mar 14, 2024
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Mar 15, 2024

I also discovered that running

yarn workspace @packages/example deploy

from a fork deploys to the fork's gh-pages branch. The web's structure is however not set up to run correctly from a fork, Only the index.html displays correctly. Navigation to other pages does not work and CSS formatting does not work on other pages either.

That may become irrelevant if the deploy process is changed. If not it should be noted in the README.

@MikeMcC399
Copy link
Contributor

Possibly something like Percy could be used for visual comparison of pending changes to https://example.cypress.io ?

@MikeMcC399
Copy link
Contributor

Current drawbacks

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Oct 3, 2024
@MikeMcC399
Copy link
Contributor

I suggest to add prevent-stale mark an issue so it is ignored by stale[bot] to this issue or if it is not going to be addressed, then close it (for instance with stage: wontfix Cypress does not regard this as an issue or will not implement this feature ).

@jennifer-shehane jennifer-shehane added prevent-stale mark an issue so it is ignored by stale[bot] and removed stale no activity on this issue for a long period labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/example This is due to an issue in the packages/example directory prevent-stale mark an issue so it is ignored by stale[bot] process: release Related to our internal release process
Projects
None yet
Development

No branches or pull requests

4 participants