-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Require @packages/example to be reviewed before deployment #29147
Comments
I also discovered that running yarn workspace @packages/example deploy from a fork deploys to the fork's That may become irrelevant if the deploy process is changed. If not it should be noted in the README. |
Possibly something like Percy could be used for visual comparison of pending changes to https://example.cypress.io ? |
Current drawbacks
|
This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided. |
I suggest to add
prevent-stale
|
Current behavior:
@packages/example
deploys directly to production example.cypress.io as soon as the deploy command executes, via thegh-pages
tool.As a stopgap to prevent outages:
gh-pages
should be a protected branchdeploy
command in@packages/example
should open a pull request togh-pages
instead of committing directlyIn the future:
cypress-example-kitchensink
should deploy continuously to a staging environmentcypress-example-kitchensink
toexample.cypress.io
are handled via circleci in thecypress-example-kitchensink
repository, triggered by creating a github release as a part of thecypress
deploy processcypress
ci, once thecypress
release process is automatedThe text was updated successfully, but these errors were encountered: