Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default cookie jar options #27893

Open
DawidJanczak opened this issue Sep 25, 2023 · 1 comment
Open

Default cookie jar options #27893

DawidJanczak opened this issue Sep 25, 2023 · 1 comment
Labels
E2E Issue related to end-to-end testing type: feature New feature that does not currently exist

Comments

@DawidJanczak
Copy link

What would you like?

Hello,

After upgrading cypress-request and tough-cookie recently our Cypress tests keep failing because of our custom "test" domain we use to test in the browser with. tough-cookie fails with

Internal error while proxying "GET http://test:4933/my-custom-path" in MaybeAttachCrossOriginCookies:
Cookie has domain set to the public suffix "test" which is a special use domain. To allow this, configure your CookieJar with {allowSpecialUseDomain:true, rejectPublicSuffixes: false}.

The only documents around cookies I could find are https://docs.cypress.io/api/cypress-api/cookies and https://docs.cypress.io/api/commands/setcookie, but the problem here is that those cookies aren't set by the Cypress test - they're set by our app that just so happens to run in a test docker container.

It would be great if we could configure the default cookie jar as suggested by that warning message.

Why is this needed?

No response

Other

No response

@nagash77 nagash77 added type: feature New feature that does not currently exist E2E Issue related to end-to-end testing labels Sep 25, 2023
@nagash77
Copy link
Contributor

Hi @DawidJanczak thank you for submitting your feature request. I will route this to our product team for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Issue related to end-to-end testing type: feature New feature that does not currently exist
Projects
None yet
Development

No branches or pull requests

2 participants