Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular schematic generate component testing files by default #27703

Closed
geromegrignon opened this issue Aug 30, 2023 · 7 comments
Closed

Angular schematic generate component testing files by default #27703

geromegrignon opened this issue Aug 30, 2023 · 7 comments
Labels
CT Issue related to component testing stale no activity on this issue for a long period type: user experience Improvements needed for UX

Comments

@geromegrignon
Copy link

geromegrignon commented Aug 30, 2023

Current behavior

By answering 'No' to component testing support when adding Cypress for Angular with ng add @cypress/schematics, the schematic added still overrides the generic component schematic and creates a cy.ts test file in place of the spec.ts file.

Desired behavior

If Component Testing support is not chosen by adding Cypress, creating a new component with ng g generate should create a spec.ts file by using ng generate component schematic.

Test code to reproduce

  • create a Angular project npx -p @angular/cli ng new projectName
  • move to your root folder with cd projectName
  • add Cypress with ng add @cypress/schematics
  • answer 'No' to component testing support
  • create a Angular component with ng generate component home
  • a home-component.cy.ts file is created.

Cypress Version

13.0.0

Node version

v18.16.1

Operating System

macOS 13.5

Debug Logs

No response

Other

No response

@nagash77 nagash77 added the CT Issue related to component testing label Aug 30, 2023
@pgates-brownadvisory
Copy link

I'm seeing this, too. Angular CLI v15.1.6, Cypress v12.10.0.

Of note (perhaps) is that I didn't have this problem when I was using Angular CLI v13.3.0.

@miguelarcjr
Copy link

I have the same problem.

@jennifer-shehane jennifer-shehane added the type: user experience Improvements needed for UX label May 15, 2024
@Jhamu21
Copy link

Jhamu21 commented Jun 13, 2024

Same problem

@altso
Copy link

altso commented Jun 13, 2024

I started having the same problem at some point in an old project and was able to "fix" it by reordering schematics in angular.json file.

Before:

  "cli": {
    "schematicCollections": [
      "@cypress/schematic",
      "@angular-eslint/schematics",
      "@schematics/angular"
    ],
    "analytics": false
  }

After:

  "cli": {
    "schematicCollections": [
      "@schematics/angular",
      "@angular-eslint/schematics",
      "@cypress/schematic"
    ],
    "analytics": false
  }

@Jhamu21
Copy link

Jhamu21 commented Jun 14, 2024

I started having the same problem at some point in an old project and was able to "fix" it by reordering schematics in angular.json file.

Before:

  "cli": {
    "schematicCollections": [
      "@cypress/schematic",
      "@angular-eslint/schematics",
      "@schematics/angular"
    ],
    "analytics": false
  }

After:

  "cli": {
    "schematicCollections": [
      "@schematics/angular",
      "@angular-eslint/schematics",
      "@cypress/schematic"
    ],
    "analytics": false
  }

Thankyou it worked!

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 12, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing stale no activity on this issue for a long period type: user experience Improvements needed for UX
Projects
None yet
Development

No branches or pull requests

8 participants