Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker image short-form Node.js tag in examples #6047

Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Dec 16, 2024

Issue

Using the long-form tag for cypress/browsers Docker images, such as in

cypress/browsers:node-22.11.0-chrome-130.0.6723.69-1-ff-132.0-edge-130.0.2849.56-1

causes code examples to be so wide that scrolling can be necessary to view. See for example https://docs.cypress.io/app/continuous-integration/aws-codebuild#Cypress-Amazon-Public-ECR.

Starting from the release of the Cypress Docker image cypress/browsers:22.11.0, a short-form tag e.g.

22.11.0

is available, which takes far less space to display than the long-form tag e.g.

node-22.11.0-chrome-130.0.6723.69-1-ff-132.0-edge-130.0.2849.56-1

See cypress/browsers Tags.

Change

Replace all long-form tags for cypress/browser in examples with their equivalent short-form tag 22.12.0, which is the Node.js Active LTS version. The full Docker image reference is then cypress/browsers:22.12.0.

For consistency, update also cypress/base tags in examples to the same short-form tag 22.12.0.

Copy link

netlify bot commented Dec 16, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 27810da

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 16, 2024 11:47
@MikeMcC399 MikeMcC399 changed the title Use cypress/browsers Docker image short-form tag in examples Use Docker image short-form Node.js tag in examples Dec 16, 2024
@jennifer-shehane jennifer-shehane merged commit aadb936 into cypress-io:main Dec 17, 2024
5 checks passed
@MikeMcC399 MikeMcC399 deleted the update/docker-browsers-short branch December 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants