Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent horizontal scrolling coming from code blocks #5537

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

mateustav
Copy link
Contributor

@mateustav mateustav commented Oct 16, 2023

What does this do?

  • Some articles contain code blocks and tabbed code blocks that create horizontal scrolling in the document. These changes ensure the code block uses its own width (or, in the case of tabs, a max of 36rem in certain viewport sizes).

Before

Migration.Guide._.Cypress.Documentation.-.16.October.2023.mp4

After

Migration.Guide._.Cypress.Documentation.-.16.October.2023.1.mp4

How to test

  • Visit a few articles with code blocks like this one.
  • Ensure there's no horizontal scrolling no matter which viewport you view it from.
  • Ensure code blocks behave normally (you can scroll, wrap text, copy).
  • Ensure code block tabs behave normally (you can switch tabs, you can scroll through them).

@netlify
Copy link

netlify bot commented Oct 16, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8121b29

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 8121b29
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/6539447d442f6a0008f8cd1a
😎 Deploy Preview https://deploy-preview-5537--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@emilyrohrbough
Copy link
Member

@mateustav Thank you for fixing this scroll issue!

@emilyrohrbough emilyrohrbough merged commit 7361e89 into cypress-io:main Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants