Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command-line.mdx for the project spec file name seems not match the subfolder #5467

Closed
wants to merge 3 commits into from

Conversation

chengzhangHu
Copy link

the project spec file name seems not match the subfolder
image

should the project spec file name match the subfolder
@netlify
Copy link

netlify bot commented Sep 6, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8d2f6b1

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ emilyrohrbough
❌ chengzhangHu
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit 8d2f6b1
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65c218c9cd1e180008038385
😎 Deploy Preview https://deploy-preview-5467--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor

@chengzhangHu

Good catch!

I suggest instead to change the folder structure and replace integration with e2e.

integration was the default for legacy Cypress
e2e is the default for current Cypress

That would mean that the command line example stays unchanged.

BTW: You will need to sign the CLA (see above) for your PR to be processed.

@nagash77
Copy link
Contributor

nagash77 commented Sep 6, 2023

Hi @chengzhangHu , as @MikeMcC399 you will need to sign the CLA before any PRs can be accepted. I also think Mike is correct in the suggested approach. Could you please make those changes and I will get this reviewed!

@nagash77 nagash77 self-assigned this Sep 6, 2023
@MikeMcC399
Copy link
Contributor

@chengzhangHu

Are you going to continue with this PR?

You didn't respond so far to any comments.

@MikeMcC399
Copy link
Contributor

@MikeMcC399
Copy link
Contributor

@chengzhangHu

Please close this PR, since the issue has been corrected. See the close button below 🔽

Thank you for reporting the documentation problem!

Copy link
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ! Looks like we missed this updated when v10 was released.

@emilyrohrbough
Copy link
Member

Closed as @MikeMcC399 fixed this in a different PR.

@MikeMcC399
Copy link
Contributor

@emilyrohrbough

Closed as @MikeMcC399 fixed this in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants