-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module API examples incorrect for Yarn Plug'n'Play #5248
Comments
@MikeMcC399 what is the suggestion here? It doesn't appear we are using yarn in any of the commands here |
The command in the documentation I was looking at this in conjunction with the introduction of Yarn Modern Plug'n'Play support in github-action and the absence of this information threw me to begin with until I got deeper into it. I didn't even know if Module API was compatible with Yarn Modern Plug'n'Play from reading the Module API documentation.
The relevant bit of the Yarn Modern in Plug'n'Play mode documentation says:
|
So the suggestion would be to add a comment to preface the command with |
Sorry, not too familiar with yarn pnp. Is this something that a yarn person would just know they have to do if they are using pnp? Would this change entail updating all the shell examples to have a yarn pnp usage as well, or a note to yarn pnp users somewhere? |
I'll make a concrete proposal in a PR for minimal changes to the docs. I think just a note would be sufficient without updating every single example. |
That makes two of us!
I can't really answer that as I wouldn't consider myself to be a "yarn person". It's probably better not to assume too much prior knowledge. In any case I've now submitted a suggestion as PR #5254 for you to take a look at. There are currently several issues in Cypress with Yarn Plug'n'Play so I had to go back to |
Subject
Guides > Module API
Description
https://docs.cypress.io/guides/guides/module-api
For Yarn Plug'n'Play the command
node e2e-open-tests.js
needs to be executed as:The text was updated successfully, but these errors were encountered: