Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(graphql): make object property access safe #4858

Merged
merged 1 commit into from
Oct 12, 2023
Merged

docs(graphql): make object property access safe #4858

merged 1 commit into from
Oct 12, 2023

Conversation

dargmuesli
Copy link
Contributor

See https://eslint.org/docs/latest/rules/no-prototype-builtins.

"it would be unsafe for a webserver to parse JSON input from a client and call hasOwnProperty directly on the resulting object, because a malicious client could send a JSON value like {"hasOwnProperty": 1} and cause the server to crash"

I know that it's unlikely to happen in the Cypress context, but it is always good for developers to see proper prototype access.

@netlify
Copy link

netlify bot commented Nov 12, 2022

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0d2a129

@vercel
Copy link

vercel bot commented Nov 12, 2022

@dargmuesli is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2022

CLA assistant check
All committers have signed the CLA.

@dargmuesli
Copy link
Contributor Author

dargmuesli commented Feb 27, 2023

@jaffrepaul I've rebased this PR to solve merge conflicts. Is there interest to merge this PR?
Edit: @emilyrohrbough maybe you have permissions to get this merged?

@dargmuesli
Copy link
Contributor Author

@jaffrepaul what can I do to get this merged? 🙏

@vercel
Copy link

vercel bot commented Oct 11, 2023

Deployment failed with the following error:

There is no GitHub account connected to this Vercel account.

@mschile mschile self-assigned this Oct 12, 2023
@mschile mschile merged commit a53c5ba into cypress-io:main Oct 12, 2023
@mschile
Copy link
Contributor

mschile commented Oct 12, 2023

Hi @dargmuesli 👋, thanks for the contribution and sorry for taking so long to get it merged!

@dargmuesli
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants