-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update clashing types with jest answer #4600
docs: update clashing types with jest answer #4600
Conversation
@bchen1029 is attempting to deploy a commit to the Cypress Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
Hoping this is a major priority! thx~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please merge this!
Hey @bchen1029 I also needed to add Not sure if it was something on my end but just in case the docs should reflect it. {
"exclude": ["cypress.config.ts", "cypress", "node_modules"]
} We are using |
@garmeeh really appreciate! just wanna confirm that I also need to add |
@bchen1029 sorry, I missed the notification on your reply. I wasn’t 100% sure on if node_modules should be there but seen some examples with it so added it. I don’t think it is doing any harm being there anyway. |
@maria-kravtsova @elylucas @rockindahizzy |
@elylucas I'm not sure how the Vercel authorization step works? |
I created a new PR to track this since this one is so out of date #5514 |
closes #4559
see: cypress-io/cypress#22059 for discussion