Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching a secondary workflow from within a main workflow with ROSE variables corrupts the environment #355

Open
ColemanTom opened this issue Dec 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ColemanTom
Copy link

Description

If you have have a workflow, and it does cylc vip to launch another workflow, from within a ROSE app, the second workflow gets confused as the ROSE variables are passed through.

NOTE: I thought this should go in this repo but happy to be corrected if it should be in the rose repo.

Workaround

Current workaround is to do unset "${!ROSE_@}" before cylc vip to ensure they are unset.

Reproducible Example

rose_app_launch_corruption.tar.gz

Download the above. Check its contents to make sure I'm not doing anything nefarious. Then, run the run.sh in the top level.

The launcher workflow launches the runner workflow. If I look at the log for the only task in runner, this is the job.out:

$ cat cylc-run/runner/log/job/20201010T0000Z/run_stuff/NN/job.out
Workflow : runner
Job : 20201010T0000Z/run_stuff/01 (try 1)
User@Host: username@hostname

2024-12-19T23:54:10Z INFO - started
[INFO] export PATH=.....
[INFO] command: launch.sh
$ cylc validate /home/username/rose_app_launch_corruption/runner
Valid for cylc-8.3.6
$ cylc install /home/username/rose_app_launch_corruption/runner

The run_stuff app should be doing an echo.

$ cat cylc-run/runner/app/run_stuff/rose-app.conf
[command]
default=echo "I am running stuff"

Expected Behaviour

The second workflow should not think it is the first workflow. And the tasks should not think they are the launching workflows task.

@ColemanTom ColemanTom added the bug Something isn't working label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant