Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: OK and Cancel on Configuration Window #17

Open
pknoot opened this issue Jan 30, 2021 · 3 comments
Open

Feature request: OK and Cancel on Configuration Window #17

pknoot opened this issue Jan 30, 2021 · 3 comments
Assignees

Comments

@pknoot
Copy link

pknoot commented Jan 30, 2021

Can we have OK and Cancel buttons on the Configuration Window?

@djowel
Copy link
Member

djowel commented Jan 31, 2021

What's interesting is that you have an advanced version v1.1.0 which I am just about to release.

The idea is that the Configuration Window is non-modal. In modern GUI land, modal windows are rather passé. Have a look at modern UIs, for example, MacOS System Preferences. Here's an example:

Screen Shot 2021-01-31 at 10 25 37 AM

Take note that there is no OK and Cancel button. It is non-modal. The same is true with modern mobile preferences pages.

The idea is that the setting takes effect immediately. You do not have to click on an OK button. In fact, you can move the window aside, and continue working/playing, adjust other controls, etc. and it will not prevent you from doing so, and you will have instant feedback on your current setting.

Such non-modal windows are becoming quite common now. It is the same idea behind Adobe Photoshop's more modern settings windows, as another example:

Screen Shot 2021-01-31 at 10 35 19 AM

@pknoot
Copy link
Author

pknoot commented Jan 31, 2021

I totally get that. My concern was primarily if a mistake was made on the Configuration window and one wanted to cancel without making the current settings active, particularly if one forgot what was there in the first place.

@djowel
Copy link
Member

djowel commented Jan 31, 2021

I totally get that. My concern was primarily if a mistake was made on the Configuration window and one wanted to cancel without making the current settings active, particularly if one forgot what was there in the first place.

Well, one could argue that you can also commit that mistake of forgetting what was once there in any of the controls, right? Most DAWs have an undo change or revert capability as a general features for such cases when you want to go back to a prior state. In Logic pro, for example, each plugin window has a "Compare" button that you can click to revert to a prior state after a change.

I think the use of cancelable modal dialogs are necessary only in cases where there can be a potentially negative effect of an action (e.g. Save or Save As dialog) that will require your attention. Modal dialogs are still necessary, in such cases.

@djowel djowel self-assigned this Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants