Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

sub criteria - unit awards - not working properly #2

Open
cwarwicker opened this issue Jul 27, 2017 · 1 comment
Open

sub criteria - unit awards - not working properly #2

cwarwicker opened this issue Jul 27, 2017 · 1 comment
Labels
bug medium Medium Priority parked Parked until a later date

Comments

@cwarwicker
Copy link
Owner

The BTEC rules are not working properly with sub criteria.

It should be that only the parents need to be ticked, e.g. P1, P2 for a pass, and P1.1, P2.1 can be ignored. But it currently needs all of them ticked.

In addition to this, the event notification is not done if the criterion saved is a sub criteria, so if you have P1, P1.1, P2 all ticked and then you tick P2.1, the unit award doesn't change. But if you have P1, P1.1, P2.1 ticked and then you tick P2, it does.

So all in all its a mess.

Need to decide what SHOULD happen:

  • SHOULD all the sub criteria be required or not?
  • If so, need to look at updating the parent when all children are ticked, and then still running the events, without infinite looping
  • If NOT, then need to change how the rules are done, to allow us to specify only parent criteria.
@cwarwicker cwarwicker added the bug label Jul 27, 2017
@cwarwicker cwarwicker added the medium Medium Priority label Jul 16, 2019
@cwarwicker cwarwicker added the parked Parked until a later date label Nov 5, 2019
@cwarwicker
Copy link
Owner Author

I'm parking this until I can hopefully get some feedback about BTECs and exactly how they should be working nowadays,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug medium Medium Priority parked Parked until a later date
Projects
None yet
Development

No branches or pull requests

1 participant