Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link-button confusion #21

Open
jrpool opened this issue Jun 17, 2022 · 0 comments
Open

Link-button confusion #21

jrpool opened this issue Jun 17, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed new test proposal for a new test

Comments

@jrpool
Copy link
Collaborator

jrpool commented Jun 17, 2022 •
edited by poolcvs
Loading

Add a rule to testaro that prohibits links that look like buttons.

The “New issue” link on this page is an example. It is indistinguishable visually from the “Update comment” button but is a link.

This seems like a good rule to implement validator-first.

A rule prohibiting buttons that look like links could also be implemented, but that practice seems to be very rare.
@jrpool jrpool added the recommendation Advice on a change to make label Jun 17, 2022
@jrpool jrpool self-assigned this Jun 17, 2022
@jrpool jrpool added the new test proposal for a new test label Jun 23, 2022
@poolcvs poolcvs added enhancement New feature or request help wanted Extra attention is needed and removed recommendation Advice on a change to make labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed new test proposal for a new test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrpool @poolcvs