Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing the package messes up my projects that have a tests module #90

Open
Diveafall opened this issue Dec 11, 2022 · 2 comments
Open

Installing the package messes up my projects that have a tests module #90

Diveafall opened this issue Dec 11, 2022 · 2 comments

Comments

@Diveafall
Copy link

Correct me if I'm wrong, but most projects tend to have a tests directory where they keep all their tests. Installing customerio messes up my projects where I'm importing from tests since it assumes I'm importing from customerio. This should be remedied IMO.

Thoughts?
@louison
Copy link

louison commented Jul 21, 2023

I second @Diveafall. I don't think it is a good idea to ship customer.io tests along with the customer.io package

@louison
Copy link

louison commented Jul 21, 2023 •
edited
Loading

For example, all python libs shipped by Google only include packages starting with the google namespace in their distribution (see here for example)

@louison louison mentioned this issue Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Diveafall @louison