Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move related_transaction out of QueryParams #193

Open
matin opened this issue Jan 17, 2022 · 1 comment
Open

move related_transaction out of QueryParams #193

matin opened this issue Jan 17, 2022 · 1 comment

Comments

@matin
Copy link
Member

matin commented Jan 17, 2022

related_transaction should not be directly specified in QueryParams:
https://github.com/cuenca-mx/cuenca-validations/blob/main/cuenca_validations/types/queries.py#L32

It should be moved elsewhere

@alexviquez
Copy link
Member

move to BalanceEntryQuery:

class BalanceEntryQuery(QueryParams):
    funding_instrument_uri: Optional[str] = None
    related_transaction_uri: Optional[str] = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants