Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling ⚠️ #24

Open
2 of 5 tasks
euisuny opened this issue Oct 28, 2018 · 1 comment
Open
2 of 5 tasks

Improve error handling ⚠️ #24

euisuny opened this issue Oct 28, 2018 · 1 comment
Assignees
@euisuny
Labels
good first issue Good for newcomers

Comments

@euisuny
Copy link
Member

euisuny commented Oct 28, 2018 •
edited by Checkmate50
Loading

A few things that could be introduced for improved error handling:

  • Line number printing in type checker 🔢
  • Improve line number/character printing in parser (currently has a few bugs) 🐛
  • Detailed error types (rather than generic TypeCheckException) 🍡
  • Error formatting (i.e. write a error formatter) 🗒
  • Introduce flags for outputting compiler warnings that are not exceptions/errors 🎏
@euisuny euisuny self-assigned this Oct 28, 2018
@sampsyo
Copy link
Contributor

sampsyo commented Oct 28, 2018

Nice! Here's one small tip: I had to sort out the "modern way" to do line/column number reporting for ocamllex/ocamlyacc for the latest 4110 assignment. Perhaps this will be relevant to our Menhir-based parser too. Here are the relevant lines:

https://github.com/cs4110/2018fa/blob/b63ceffb3512221dacaa4aa9b1bb695104c465a5/homework/homework07code/lexer.mll#L15

https://github.com/cs4110/2018fa/blob/b63ceffb3512221dacaa4aa9b1bb695104c465a5/homework/homework07code/main.ml#L28-L29

@Checkmate50 Checkmate50 added the good first issue Good for newcomers label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@euisuny euisuny

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sampsyo @Checkmate50 @euisuny