Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password sometimes lacks given character classes #8

Open
Sebbb opened this issue Oct 11, 2021 · 3 comments
Open

Password sometimes lacks given character classes #8

Sebbb opened this issue Oct 11, 2021 · 3 comments

Comments

@Sebbb
Copy link

Sebbb commented Oct 11, 2021

Hello,

a password generated with
new_password = Passgen::generate(length: 20, symbols: true, uppercase: true, lowercase: true, digits: true)
was
@LwShlWaQ)uks$nDeaGc

Note that there is no digit in. I would expect digits: true to ensure that the password at least includes one character of this class, not that it may include these.

In any case, the description is not clear on if it may or will include a specific character class.

@aaron-jones-provi
Copy link

I'm noticing the same thing with symbols: true - in 2/3 test generations it included symbols, one did not.

@nicklunn325
Copy link

Was just attempting to use and had the same issue, doesn't guarantee use of symbol when symbols: true is provided as an an argument

@shaneshort
Copy link

this explains some of my test failures, I'm glad I found this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants