This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor to 2021 standards #35
Draft
rossjrw
wants to merge
25
commits into
master
Choose a base branch
from
big-ol-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjrw
force-pushed
the
big-ol-refactor
branch
from
April 10, 2021 16:19
d42aafa
to
2f6276a
Compare
rossjrw
force-pushed
the
big-ol-refactor
branch
from
April 13, 2021 03:29
67a092b
to
5b301c4
Compare
This information does still need to be presented somehow, but an app (i.e. a section of the interface, accessible to the player during standard gameplay) is not the way to do it.
rossjrw
force-pushed
the
big-ol-refactor
branch
from
April 20, 2021 16:05
4751135
to
a25ba42
Compare
rossjrw
force-pushed
the
big-ol-refactor
branch
from
April 24, 2021 23:42
a25ba42
to
4bfdc27
Compare
Merged
This was referenced Jun 17, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright. This is going to be a big one. I may need to split it out into multiple PRs as convenient.
The gist at the time of writing is that I have an old spreadsheet-based CoffeeScript project, and a partially-converted TypeScript project from the previous version of this PR. I also have a whole bunch of planning for an entirely new plot, and a whole bunch of writing for an old one. So, I'm going to scrap all the work I did converting that stuff to the new format (as well as the new format itself), and start over from scratch - but this time with an actual configuration format. I can then cherry-pick anything worth keeping from the old stuff as and when I want it.
Cleaning up
.gitattributes
Engine
aic.bootUp
with a game start hook callback, or something)Styling
transition
property and ensure it is never set toall
Build process
Events
TOMLJSON event file with some sample interactions (closes move LoopService.js compilation from google sheets to internal #23)