Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Refactor to 2021 standards #35

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Refactor to 2021 standards #35

wants to merge 25 commits into from

Conversation

rossjrw
Copy link
Member

@rossjrw rossjrw commented Jan 13, 2021

Alright. This is going to be a big one. I may need to split it out into multiple PRs as convenient.

The gist at the time of writing is that I have an old spreadsheet-based CoffeeScript project, and a partially-converted TypeScript project from the previous version of this PR. I also have a whole bunch of planning for an entirely new plot, and a whole bunch of writing for an old one. So, I'm going to scrap all the work I did converting that stuff to the new format (as well as the new format itself), and start over from scratch - but this time with an actual configuration format. I can then cherry-pick anything worth keeping from the old stuff as and when I want it.

Cleaning up

  • Delete all the old events
  • Scrap the spreadsheet and LoopService.js
  • Scrap anything that requires the .gitattributes
  • Scrap jQuery
  • Scrap AngularJS
  • Don't commit builds (dist/)
  • Scrap old images, where appropriate
  • Convert CSS to SCSS (closes Switch to SCSS #39)
  • Use SCSS variables in place of CSS variables where appropriate
  • Set up Prettier
  • Run Prettier in pre-commit
  • Add updated licensing info (README.md and LICENSE)

Engine

  • Scrap CoffeeScript
  • Convert everything to TypeScript
  • Create a shitload of Vue 3 components
  • Split HTML across Vue components
  • Make the Vue components work
  • Try to keep Maitreya logic and game engine logic isolated from each other (e.g. replace aic.bootUp with a game start hook callback, or something)

Styling

Build process

  • Build and deploy automatically with GitHub Actions
  • Isolate anything English into a language dir, like I did for 3211
  • Create a language-agnostic bundle via Webpack

Events

@rossjrw rossjrw added the enhancement do something better label May 9, 2021
@rossjrw rossjrw mentioned this pull request May 14, 2021
This was referenced Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement do something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to SCSS move LoopService.js compilation from google sheets to internal
1 participant