-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlcipher or any encryption #92
Comments
No plans yet but thanks for putting it on my radar. From my first look at sqlcipher I'm not sure it's a good idea to force this change on users. I would be open to an approach that used build tags to select whether sqlcipher is used. Basically an opt in feature. If this is something you are interested in spearheading I would be grateful for the contribution. |
I've been searching around and I found bunch of other implementations regarding the stream cipher, and I found this, It's by far simplest and smallest compare to others but I'm a little bit worried about protocol and implementation of that. Most of the case, people should not write their own crypto package. I'd would love to help to push this forward but I need some guidance, maybe some documentation on how to integrate cipher into sql and let user decide what they want to use. |
Hello @AdamSLevy, There are couple of issues:
This is as far as I can go since I don't have a deep knowledge of this library and I was hoping you can guide me through this. |
Awesome work. Thank you. I took a closer look at both projects. I personally prefer sqlcipher as it seems like a more mature project. That being said, the techniques required to support either are going to be very similar, and they even use the exact same C API, which allows for the Go code to not change no matter which extension is selected. Are you familiar with Go build tags? This is the technique I would like to use to allow for conditional compilation of these features. For example if a user wanted to use SQLeet, they'd use a tag in their build like so:
If you're not familiar these articles are good, I took a close look at your branch. Will you please open a PR so we can more easily comment on and discuss code changes? There were a number of issues with the example code, and with how you were setting the key, but ultimately I got it working. If you open a PR, then I can push my changes and I will review your code with comments explaining some things I'd like to see in more detail.
This is because by default this package creates databases in WAL mode which is a setting that must be read from the database header when opening an existing file. However the header is encrypted and so reading fails because the WAL mode option has not been read. This can be dealt with by using a URI that sets the key and the journal mode like this: See the section right above this linked section in the README: https://github.com/resilar/sqleet#uri-configuration-interface Great work. This is looking really do-able and will be a great added feature. |
@AdamSLevy Thank you for your support, Thanks |
Is there any roadmap to use/port in sqlcipher or any other encryptions into this library?
The text was updated successfully, but these errors were encountered: