Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing with runtime/trace #49

Open
crawshaw opened this issue Dec 20, 2018 · 2 comments
Open

tracing with runtime/trace #49

crawshaw opened this issue Dec 20, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@crawshaw
Copy link
Owner

If sqlite.Pool moves to sqlitex as described in #47, it can take a context and that opens up the possibility of using runtime/trace for tracing.

As the sqlite package cannot depend on context, the trace object will have to be passed in from sqlitex using an adapter. That's easy enough.

A potential problem: what does tracing mean for an sqlite query? Commands like INSERT or UPDATE or SELECTs with a single call to sqlite3_step are easy, but multi-row queries are processed incrementally, so accounting is tricky.

@AdamSLevy
Copy link
Collaborator

AdamSLevy commented Dec 10, 2019

Why can the sqlite package not depend on context?

In another issue I realized that you are avoiding context to avoid importing reflect for ease of use with tinygo.

@AdamSLevy
Copy link
Collaborator

Is tracing implemented in sqlitex at this point?

@AdamSLevy AdamSLevy added the enhancement New feature or request label Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants