Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct Feed URL returns 200 OK on request that fails to queue the task #1567

Open
jamesmacwhite opened this issue Dec 31, 2024 · 0 comments
Open
Labels

Comments

@jamesmacwhite
Copy link
Contributor

Description

When using the Direct Feed URL provided by Feed Me to trigger a feed via HTTP request to trigger a queue job, if for any reason the queue job can't be triggered or there is an issue with the URL parameters, the action controller returns an error message, but the response code on the template is 200 OK. For automated systems that might use the Direct Feed URL and use the status code for determining an error, this is potentially something that could mask a problem and go undetected, unless specifically parsing the page content after.

Steps to reproduce

  1. Get a valid Direct Feed URL from an a feed
  2. Modify a parameter such as the passkey to be invalid
  3. The request will return an error page, but the underlying status code is still 200 OK.

Additional info

  • Craft version: 5.5.7
  • PHP version: 8.3
  • Database driver & version: MySQL 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant