Avoid reload of Live Preview iframe on device type selection #10353
-
|
The iframe containing the live preview target is reloaded when changing device preview – is this always necessary? Having the option to not reload the iframe would be very welcome.
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
|
@joshangell any thoughts on this? |
Beta Was this translation helpful? Give feedback.
-
|
I’ve just had a quick refresher of the code, and it seems this line is the one triggering it: https://github.com/craftcms/cms/blob/develop/src/web/assets/cp/src/js/Preview.js#L604 You could try omitting the second parameter and see if nothing breaks, but there is probably a reason it forces a reload - I just failed to comment it ... |
Beta Was this translation helpful? Give feedback.
-
|
Got this working for the next release! (26d3c8e) |
Beta Was this translation helpful? Give feedback.
-
|
Well that was more complex than I thought! |
Beta Was this translation helpful? Give feedback.
-
Fantastic, thank you so much Brandon! 🏆 |
Beta Was this translation helpful? Give feedback.
-
|
Craft 3.7.29 is out now with that change ✨ |
Beta Was this translation helpful? Give feedback.
Got this working for the next release! (26d3c8e)