Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion Webhooks #71

Open
gerred opened this issue Oct 7, 2019 · 3 comments
Open

Conversion Webhooks #71

gerred opened this issue Oct 7, 2019 · 3 comments
Milestone

Comments

@gerred
Copy link
Contributor

gerred commented Oct 7, 2019

Are there plans to enable Bonny to have abstractions over conversion webhooks?

@coryodaniel
Copy link
Owner

Yeah, it'll probably be a part the effort to support mutating and validation webhooks (#15) which hasn't been started yet.

@gerred
Copy link
Contributor Author

gerred commented Oct 9, 2019

I can take a look at some of that. Bonny's pretty cool! This is my favorite alternative to what I'm working on in the controller-runtime/KUDO space right now.

@coryodaniel
Copy link
Owner

Thats awesome to here! Kudo looks pretty cool!

Webhooks would be good to see in one of the the next miles when prometheus (#4) endpoints are added since it'll require an HTTP server.

I was planning to implement Webhooks using the same 'server' abstractions and simply require a handler function.

def MyWebhook do
  use Bonny.Server.MutatingWebhook, %{...config...}

  def mutate(request), do: ...
end

@coryodaniel coryodaniel added this to the 0.5 release milestone Oct 23, 2019
@coryodaniel coryodaniel modified the milestones: 0.5 release, 1.0 release Jun 2, 2020
@mruoss mruoss modified the milestones: 1.0 release, 1.1 Release Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants