Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define custom request headers for logmarker requests #172

Open
4lisalehi opened this issue Jul 29, 2023 · 2 comments
Open

Ability to define custom request headers for logmarker requests #172

4lisalehi opened this issue Jul 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@4lisalehi
Copy link
Contributor

4lisalehi commented Jul 29, 2023

Hi,

Currently, such behavior is implemented for the actual tests using the config field testoverride.input.headers of type map. Per my tests, these custom request headers are not used in the logmarker requests.

Considering the same configurability for the logmarker requests and extending its config API with this feature, makes it more flexible and avoids potential unnecessary logic customization or configuration on the custom WAF servers side.

If I'm missing any point here, I'd appreciate your clarifying it.

Thanks.

@theseion
Copy link
Collaborator

theseion commented Aug 2, 2023

Thanks @4lisalehi. I understand what you need. We'll need to add a new option for that.

@theseion theseion added the enhancement New feature or request label Aug 2, 2023
@theseion
Copy link
Collaborator

@4lisalehi The name of the log marker header can be set through the LogMarkerHeaderName field in the configuration file. Is that good enough for you? Otherwise, I might not have understood what you asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants