You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think login1.Conn name is not very accurate, as it leaks the abstraction on how login1 methods are called underneath (via some kind of connection).
Also, right now login1 package is responsible for connecting and authenticating to D-Bus, which seems like both possible waste of resources, as multiple clients can't share the connection and it also affects testability of code, as no mock D-Bus connection can be given to a login1 client. It seems like responsibility to proxy connections to D-Bus should be out of scope for this package/struct.
The text was updated successfully, but these errors were encountered:
I think
login1.Conn
name is not very accurate, as it leaks the abstraction on how login1 methods are called underneath (via some kind of connection).Also, right now login1 package is responsible for connecting and authenticating to D-Bus, which seems like both possible waste of resources, as multiple clients can't share the connection and it also affects testability of code, as no mock D-Bus connection can be given to a login1 client. It seems like responsibility to proxy connections to D-Bus should be out of scope for this package/struct.
The text was updated successfully, but these errors were encountered: