Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White/black lists for relays #420

Open
8 tasks
Tracked by #209
staab opened this issue Sep 18, 2024 · 2 comments
Open
8 tasks
Tracked by #209

White/black lists for relays #420

staab opened this issue Sep 18, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@staab
Copy link
Collaborator

staab commented Sep 18, 2024

  • Global setting for what to do when connecting to a relay not on the user's list: always, never, confirm (default)
  • Global setting for whether to auth with unknown relays: always, never, confirm (default)
  • When authing with a new relay, ask user permission based on the global setting and add to auth whitelist
  • When selecting relays, penalize relays that the user hasn't connected to, or that have been blacklisted
  • Show notification on relays navigation item when relay approvals are pending
  • Redesign relays page or HUD to include advanced settings for relays
  • Use welshman/thunk instead of publishes
  • Measure invalid or muted events getting returned by relay, if the rate is significant warn the user somehow
@staab staab added the enhancement New feature or request label Sep 18, 2024
@staab staab added this to the 0.5.0 milestone Sep 18, 2024
@staab staab mentioned this issue Sep 18, 2024
8 tasks
@dtonon
Copy link
Member

dtonon commented Oct 15, 2024

Are we sure we want to have the confirmation action as the default for the connection? It can disrupt the functionality and be quite annoying for a standard user; we tested this with Gossip when it added this confirmation option.
For login, on the other hand, a more rigid default setting may be fine, as the user attests to identity and there should be fewer requests for confirmation.

An additional solution is to add to the onboarding a "Privacy / security" step where the user in formed about these possibilities and can tune the preferences.

@staab
Copy link
Collaborator Author

staab commented Oct 15, 2024

Are we sure we want to have the confirmation action as the default for the connection? It can disrupt the functionality and be quite annoying for a standard user; we tested this with Gossip when it added this confirmation option.

I agree. I think the kind of chatty confirmation signers do is an anti-pattern, and we shouldn't duplicate it if at all possible for relay connections. Reasonable defaults and a few different modes based on user paranoia would allow us to reduce the friction for normal users, so that we're only asking for the sketchiest of relays (relays completely outside their network for example).

@staab staab modified the milestones: 0.5.0, 0.6.0 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants